<html>
<head><meta charset="utf-8"><title>TLS · wg-traits · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/index.html">wg-traits</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/TLS.html">TLS</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="192177749"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/TLS/near/192177749" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Florian Diebold <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/TLS.html#192177749">(Mar 29 2020 at 14:43)</a>:</h4>
<p>Currently it's not possible to run the test suite with CHALK_DEBUG, almost everything fails with <code>not implemented: cannot format Substitution without setting Program in tls</code> <span aria-label="sad" class="emoji emoji-2639" role="img" title="sad">:sad:</span></p>



<a name="192177809"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/TLS/near/192177809" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/TLS.html#192177809">(Mar 29 2020 at 14:44)</a>:</h4>
<p>There's a PR I need to do for that</p>



<a name="192177827"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/TLS/near/192177827" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/TLS.html#192177827">(Mar 29 2020 at 14:45)</a>:</h4>
<p>Basically all those unimplemented should print the interned var if the program isn't present in tls</p>



<a name="192177838"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/TLS/near/192177838" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/TLS.html#192177838">(Mar 29 2020 at 14:45)</a>:</h4>
<p>I can do that when I get up and push the fix</p>



<a name="192177912"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/TLS/near/192177912" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Florian Diebold <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/TLS.html#192177912">(Mar 29 2020 at 14:47)</a>:</h4>
<p>it might also be possible to fix the places that don't set TLS in the tests, I hope</p>



<a name="192177988"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/TLS/near/192177988" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Florian Diebold <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/TLS.html#192177988">(Mar 29 2020 at 14:48)</a>:</h4>
<p>I found one place, but it apparently wasn't enough. I'll debug it some more later</p>



<a name="192196417"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/TLS/near/192196417" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/TLS.html#192196417">(Mar 29 2020 at 22:03)</a>:</h4>
<p>yeah, I was running into this with rustc integration work</p>



<a name="192196492"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/TLS/near/192196492" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/TLS.html#192196492">(Mar 29 2020 at 22:05)</a>:</h4>
<p>The problem is really that all the debug* functions in <code>Interner</code> return <code>None</code> and that causes them to fail</p>



<a name="192196535"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/TLS/near/192196535" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/TLS.html#192196535">(Mar 29 2020 at 22:06)</a>:</h4>
<p>the unimplemented message isn't really accurate</p>



<a name="192196547"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/TLS/near/192196547" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/TLS.html#192196547">(Mar 29 2020 at 22:06)</a>:</h4>
<p>I'll actually just make a PR now to fix this</p>



<a name="192196619"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/TLS/near/192196619" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/TLS.html#192196619">(Mar 29 2020 at 22:08)</a>:</h4>
<p>There's a couple parts here:</p>



<a name="192196696"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/TLS/near/192196696" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/TLS.html#192196696">(Mar 29 2020 at 22:10)</a>:</h4>
<p>1) we need a way to accessed the internedtype given the wrapper ty (e.g. I::InterernedType from Ty&lt;I&gt;)</p>



<a name="192196709"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/TLS/near/192196709" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/TLS.html#192196709">(Mar 29 2020 at 22:10)</a>:</h4>
<p>2) debug impls should fall back to <em>some</em> kind of debug</p>



<a name="192196718"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/TLS/near/192196718" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/TLS.html#192196718">(Mar 29 2020 at 22:11)</a>:</h4>
<p>maybe something like "Ty(?)"</p>



<a name="192196797"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/TLS/near/192196797" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/TLS.html#192196797">(Mar 29 2020 at 22:12)</a>:</h4>
<p>in the future, we should/could think about a better way to consistently get the interner passed through in some non-TLS manner, so Interners that don't store the interned types as &amp;TyData or Box&lt;TyData&gt; can still debug properly without TLS</p>



<a name="192196989"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/TLS/near/192196989" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/TLS.html#192196989">(Mar 29 2020 at 22:18)</a>:</h4>
<p>or maybe we might just want debug* functions in Interner to just return Result&lt;(), fmt::Error&gt;</p>



<a name="192196995"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/TLS/near/192196995" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/TLS.html#192196995">(Mar 29 2020 at 22:18)</a>:</h4>
<p>and provide default methods</p>



<a name="192197175"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/TLS/near/192197175" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/TLS.html#192197175">(Mar 29 2020 at 22:23)</a>:</h4>
<p>mmm nah, because then it would be more difficult to conditionally fall back to default debug output</p>



<a name="192197182"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/TLS/near/192197182" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/TLS.html#192197182">(Mar 29 2020 at 22:24)</a>:</h4>
<p>will have a default body of None though</p>



<a name="192197881"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/TLS/near/192197881" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/TLS.html#192197881">(Mar 29 2020 at 22:43)</a>:</h4>
<p><a href="https://github.com/rust-lang/chalk/pull/366" title="https://github.com/rust-lang/chalk/pull/366">https://github.com/rust-lang/chalk/pull/366</a> if anyone wants to review</p>



<a name="192307732"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/TLS/near/192307732" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/TLS.html#192307732">(Mar 30 2020 at 19:45)</a>:</h4>
<p><span class="user-mention" data-user-id="232957">@Jack Huey</span> left some comments on <a href="https://github.com/rust-lang-nursery/chalk/issues/366" title="https://github.com/rust-lang-nursery/chalk/issues/366">chalk#366</a></p>



<a name="192308891"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/TLS/near/192308891" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/TLS.html#192308891">(Mar 30 2020 at 19:53)</a>:</h4>
<p>Let me fix those</p>



<a name="192310675"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/TLS/near/192310675" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/TLS.html#192310675">(Mar 30 2020 at 20:06)</a>:</h4>
<p><span class="user-mention" data-user-id="116009">@nikomatsakis</span>  addressed your comments</p>



<a name="192316217"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/TLS/near/192316217" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/TLS.html#192316217">(Mar 30 2020 at 20:55)</a>:</h4>
<p>Merged</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>